fix: spacing after list in rich text editor [WPB-15685] #18720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18720 +/- ##
=======================================
Coverage 45.72% 45.73%
=======================================
Files 944 944
Lines 27872 27876 +4
Branches 6289 6292 +3
=======================================
+ Hits 12745 12748 +3
- Misses 13536 13537 +1
Partials 1591 1591 |
waseemansar
force-pushed
the
fix/list-spacing-WPB-15685
branch
from
6004ce8 to
a393333
Compare
olafsulich
approved these changes
Feb 10, 2025
przemvs
reviewed
Feb 10, 2025
| @@ -27,7 +27,7 @@ import {replaceInRange} from './StringUtil'; | |||
| import type {MentionEntity} from '../message/MentionEntity'; | |||
|
|
|||
| interface MentionText { | |||
| domain: string | null; | |||
| domain: string | null | undefined; | |||
There was a problem hiding this comment.
Suggested change
| domain: string | null | undefined; | |
| domain?: string | null; |
There was a problem hiding this comment.
There was a typescript error for below code.
mentionTexts[mentionKey] = {
domain: mention.domain,
mention.domain can be undefined.
olafsulich
reviewed
Feb 10, 2025
src/script/util/messageRenderer.ts
Outdated
| @@ -99,6 +99,15 @@ markdownit.renderer.rules.paragraph_open = (tokens, idx) => { | |||
| .find(({map}) => map?.length); | |||
| const previousPosition = previousWithMap ? (previousWithMap.map || [0, 0])[1] - 1 : 0; | |||
| const count = position - previousPosition; | |||
|
|
|||
| // Check if the previous token was a list (either bullet or ordered) | |||
There was a problem hiding this comment.
imo this comment is redundant, the code describes itself enough
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues:
domainproperty in theMentionTextinterface.Changes:
paragraph_openandparagraph_closerules inmessageRenderer.tsto handle empty lines correctly only for lists.<br>tags for empty lines between paragraphs.MentionTextinterface to allowdomainto be of typestring | null | undefined.Screenshots/Screencast (for UI changes)
Before
After
Checklist