Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw LoaderError when failing to find a Twig template #1101

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Apr 14, 2024

Reported by: @damsfx
Credit: @LukeTowers

throw a Twig\Error\LoaderError exception so that ignore_missing works in below example:

{{ source("template", ignore_missing = true) }}

@mjauvin mjauvin added maintenance PRs that fix bugs, are translation changes or make only minor changes needs review Issues/PRs that require a review from a maintainer labels Apr 14, 2024
@mjauvin mjauvin added this to the 1.2.6 milestone Apr 14, 2024
@mjauvin mjauvin requested a review from LukeTowers April 14, 2024 12:31
@mjauvin mjauvin self-assigned this Apr 14, 2024
@LukeTowers LukeTowers added Status: Completed and removed needs review Issues/PRs that require a review from a maintainer labels Apr 15, 2024
@LukeTowers LukeTowers changed the title Twig loader must throw LoaderError Throw LoaderError when failing to find a Twig template Apr 15, 2024
@LukeTowers LukeTowers merged commit 05481c6 into develop Apr 15, 2024
12 checks passed
@LukeTowers LukeTowers deleted the fix-twig-loader branch April 15, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants