-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Font Awesome building and handling (update to 6.5.2) #1096
Conversation
- Bring in Font Awesome through NPM - Build core styles and Font Awesome through Winter Mix - Copy webfonts from FA vendor directly dynamically - Upgrade to latest FA6 release
The Workshop theme now has a page that allows you to review the available Font Awesome icons. You can install it then navigate to CMS -> Font Awesome Icons. |
modules/backend/formwidgets/permissioneditor/assets/css/permissioneditor.css
Outdated
Show resolved
Hide resolved
@bennothommo this might cause problems with how I load in the fonts on the frontend for use in my EasyForms plugin (as well as a simplified version for just icons):
@base_path: "../../../../..";
// @base_path: "../../../../../Core/winter";
@winterAssets: "@{base_path}/modules/backend/assets/less";
@stormAssets: "@{base_path}/modules/system/assets/ui/less";
@import "@{winterAssets}/core/boot.less";
@font-path: "/modules/system/assets/ui/font";
@image-path: "/modules/system/assets/ui/images";
@icon-font-path: @font-path;
.unit-selector {
@import "@{stormAssets}/../icons.less";
}
@import "@{stormAssets}/select.less"; |
Could we come up with a simplified way to include the icon assets in the frontend (and while we're at it maybe the select2 assets as well)? |
@LukeTowers why are you including the entire icon LESS file inside the As to how to include the icon assets easily in the frontend - the icons CSS file is already split off from the rest of Storm, and is accessible at |
After looking at it again, it's fine for https://cadets.site to just include the icons.css directly, but the reason I took that approach with the EasyForms plugin is because I didn't want to cause any conflicts with existing icon systems in themes. It's not the end of the world though, if it causes a problem for someone then I can always just make it optionally include that CSS and they can figure out how they want icons to work in their theme themselves. |
php artisan mix:update
to get latest Font Awesome version.Fixes #1090