Code optimization for scheduler API.

Author: twose

swoole_coroutine.h

@@ -158,28 +158,22 @@ class PHPCoroutine
 
     static inline bool enable_scheduler()
     {
-        if (get_cid() > 0)
+        php_coro_task *task = (php_coro_task *) Coroutine::get_current_task();
+        if (task && task->enable_scheduler == 0)
         {
-            php_coro_task *task = (php_coro_task *) Coroutine::get_current_task();
-            if (task->enable_scheduler == 0)
-            {
-                task->enable_scheduler = 1;
-                return true;
-            }
+            task->enable_scheduler = 1;
+            return true;
         }
         return false;
     }
 
-    static inline bool disenable_scheduler()
+    static inline bool disable_scheduler()
     {
-        if (get_cid() > 0)
+        php_coro_task *task = (php_coro_task *) Coroutine::get_current_task();
+        if (task && task->enable_scheduler == 1)
         {
-            php_coro_task *task = (php_coro_task *) Coroutine::get_current_task();
-            if (task->enable_scheduler == 1)
-            {
-                task->enable_scheduler = 0;
-                return true;
-            }
+            task->enable_scheduler = 0;
+            return true;
         }
         return false;
     }

swoole_coroutine_scheduler.cc

@@ -290,21 +290,12 @@ PHP_METHOD(swoole_coroutine_scheduler, list)
     zval_ptr_dtor(&zlist);
 }
 
-PHP_METHOD(swoole_coroutine_scheduler, disableScheduler)
+PHP_METHOD(swoole_coroutine_scheduler, enableScheduler)
 {
-    if (PHPCoroutine::disenable_scheduler())
-    {
-        RETURN_TRUE;
-    }
-    RETURN_FALSE;
+    RETURN_BOOL(PHPCoroutine::enable_scheduler());
 }
 
-PHP_METHOD(swoole_coroutine_scheduler, enableScheduler)
+PHP_METHOD(swoole_coroutine_scheduler, disableScheduler)
 {
-    if (PHPCoroutine::enable_scheduler())
-    {
-        RETURN_TRUE;
-    }
-    RETURN_FALSE;
+    RETURN_BOOL(PHPCoroutine::disable_scheduler());
 }
-

swoole_coroutine_scheduler.h

@@ -30,5 +30,5 @@ PHP_METHOD(swoole_coroutine_scheduler, getPcid);
 PHP_METHOD(swoole_coroutine_scheduler, getContext);
 PHP_METHOD(swoole_coroutine_scheduler, getBackTrace);
 PHP_METHOD(swoole_coroutine_scheduler, list);
-PHP_METHOD(swoole_coroutine_scheduler, disableScheduler);
 PHP_METHOD(swoole_coroutine_scheduler, enableScheduler);
+PHP_METHOD(swoole_coroutine_scheduler, disableScheduler);

swoole_coroutine_util.cc

@@ -141,8 +141,8 @@ static const zend_function_entry swoole_coroutine_util_methods[] =
     PHP_ME(swoole_coroutine_scheduler, getBackTrace, arginfo_swoole_coroutine_getBackTrace, ZEND_ACC_PUBLIC | ZEND_ACC_STATIC)
     PHP_ME(swoole_coroutine_scheduler, list, arginfo_swoole_coroutine_void, ZEND_ACC_PUBLIC | ZEND_ACC_STATIC)
     PHP_MALIAS(swoole_coroutine_scheduler, listCoroutines, list, arginfo_swoole_coroutine_void, ZEND_ACC_PUBLIC | ZEND_ACC_STATIC)
-    PHP_ME(swoole_coroutine_scheduler, disableScheduler, arginfo_swoole_coroutine_void, ZEND_ACC_PUBLIC | ZEND_ACC_STATIC)
     PHP_ME(swoole_coroutine_scheduler, enableScheduler, arginfo_swoole_coroutine_void, ZEND_ACC_PUBLIC | ZEND_ACC_STATIC)
+    PHP_ME(swoole_coroutine_scheduler, disableScheduler, arginfo_swoole_coroutine_void, ZEND_ACC_PUBLIC | ZEND_ACC_STATIC)
     /**
      * Coroutine System API
      */