Fix Swoole\Coroutine\Http\Client->setCookies() bug (swoole#2644)

Separate cookies array

Author: Yurunsoft

swoole_http_client_coro.cc

@@ -1686,7 +1686,7 @@ static PHP_METHOD(swoole_http_client_coro, setCookies)
     zval *cookies;
 
     ZEND_PARSE_PARAMETERS_START(1, 1)
-        Z_PARAM_ARRAY(cookies)
+        Z_PARAM_ARRAY_EX(cookies, 0, 1)
     ZEND_PARSE_PARAMETERS_END_EX(RETURN_FALSE);
 
     zend_update_property(swoole_http_client_coro_ce, getThis(), ZEND_STRL("cookies"), cookies);

tests/swoole_http_client_coro/cookies_set_bug.phpt

@@ -0,0 +1,50 @@
+--TEST--
+swoole_http_client_coro: cookies set bug
+--SKIPIF--
+<?php
+require __DIR__ . '/../include/skipif.inc';
+skip_if_in_travis('travis network');
+?>
+--FILE--
+<?php
+require __DIR__ . '/../include/bootstrap.php';
+
+function getCookies()
+{
+    $result = [];
+    var_dump($result); // must be empty array
+    return $result;
+}
+
+go(function () {
+    $url_info = parse_url('http://httpbin.org/cookies/set/a/1');
+    $domain = $url_info['host'];
+    $path = $url_info['path'];
+    $cli = new Swoole\Coroutine\Http\Client($domain);
+    $cli->set(['timeout' => 5]);
+    $cli->setHeaders([
+        'Host' => $domain,
+        'User-Agent' => 'Chrome/49.0.2587.3',
+        'Accept' => 'text/html,application/xhtml+xml,application/xml',
+        'Accept-Encoding' => 'gzip'
+    ]);
+
+    // first request
+    $cookies = getCookies();
+    $cli->setCookies($cookies);
+
+    Assert::assert($cli->get($path));
+
+    // second request
+    $cookies = getCookies();
+    $cli->setCookies($cookies);
+
+    Assert::assert($cli->get('/cookies'));
+});
+
+?>
+--EXPECTF--
+array(0) {
+}
+array(0) {
+}