Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): add install_args option #1581

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amittamari
Copy link

(Rework of #1580)

Often, when I'm working, my npm registry is set to the work's registry, which sometimes causes npm installations in Mason to fail.

To overcome this, I added the option to provide install_args to npm, the same as available in pip, so I can configure Mason to always use the default npm registry.

Note: I wasn't sure if I should also support it in lua/mason-core/managers/npm/init.lua, because I could not find any references where it is used (except tests). Let me know, and I can add it if needed.

@amittamari
Copy link
Author

Resolved conflicts

@amittamari
Copy link
Author

@williamboman can you please give this one a review? 🙏🏻 It's a relatively small change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants