-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error merging to master
: Circle doesn't provide CIRCLE_COMPARE_URL
#13
Comments
Hi @trezy, I can check this tonight. |
Thanks, @wilau2! |
Hey @trezy,
Are you still having the problem? |
|
For people using this docker image in CircleCI 2.1+ @SecretBase found a fix for the missing I did my best to summarize his findings and the fix below: @SecretBase's research
Source: nostalgic-css/NES.css#425 (comment) missing
|
Hey @wilau2, we're using this project for NES.css and it's been working great so far! However, we tried to release v1.0.0 this morning and hit a snag. The
commitlint_range.sh
script falls back to using theCIRCLE_COMPARE_URL
environment variable ifCIRCLE_PULL_REQUEST
isfalse
. However, when we merged our release PR tomaster
both of those environment variables werefalse
.Do you have any recommendations on how to handle this? For now I'll probably just update the config to ignore the
master
branch, but I was wondering if you had handled it a different way?Relevant links
The text was updated successfully, but these errors were encountered: