Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update-AtomsBase-0.5 #90

Merged
merged 15 commits into from
Feb 3, 2025
Merged

Feature/update-AtomsBase-0.5 #90

merged 15 commits into from
Feb 3, 2025

Conversation

yangmr04
Copy link
Collaborator

@yangmr04 yangmr04 commented Feb 1, 2025

Update to use AtomsBase 0.5

This pull request includes significant changes to the AbstractWalkers and EnergyEval modules, focusing on updating functions to use new methods for handling atomic systems and periodic boundary conditions. The changes also include improvements to the handling of atomic symbols and positions within various helper functions.

Main changes in AtomsBase:

  • Periodic() and DirichletZero() boundary conditions are deprecated. Simple booleans are used now.
  • atomic_symbol() and other similar functions now need the atom index in the particles list to work.
  • atomic_system() is now the easiest way to construct a flexible system.
  • boundary_conditions and bounding_box are no longer fields of a system, they are now periodicity and cell_vectors, respectively.

Now using up-to-date ExtXYZ and AtomsIO packages as well, as they are changed to accommodate AtomsBase 0.5.

No breaking changes in the exported method, although some output now looks different.

Resolves #89.

Key Changes:

AbstractWalkers Module:

EnergyEval Module:

  • src/EnergyEval/EnergyEval.jl: Removed exports for sort_components_by_atomic_number and split_components, as these functions are now handled within the AbstractWalkers module.
  • src/EnergyEval/atomistic_energies.jl: Refactored pbc_dist to use periodicity and cell_vectors methods for boundary conditions and box dimensions.

FreeBirdIO Module:

Tests:

Documentation preview: https://wexlergroup.github.io/FreeBird.jl/previews/PR90/

@yangmr04 yangmr04 marked this pull request as ready for review February 3, 2025 02:43
…ndling in EnergyEval and AbstractWalkers tests
@yangmr04 yangmr04 linked an issue Feb 3, 2025 that may be closed by this pull request
Copy link
Collaborator

@junchichen21 junchichen21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw many changes both in the source codes and test codes due to employing the newer version of package AtomsBase 0.5. From my perspectives, these changes make the code more readable. Good work!

@yangmr04 yangmr04 merged commit 70c3975 into dev Feb 3, 2025
12 checks passed
@yangmr04 yangmr04 linked an issue Feb 3, 2025 that may be closed by this pull request
@yangmr04 yangmr04 linked an issue Feb 3, 2025 that may be closed by this pull request
@yangmr04 yangmr04 deleted the feature/update-AtomsBase-0.5 branch February 3, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants