-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update-AtomsBase-0.5 #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Walkers, EnergyEval, FreeBirdIO, and MonteCarloMoves
…ated include in EnergyEval
…ic_system and adjust boundary conditions
…ndling in EnergyEval and AbstractWalkers tests
junchichen21
reviewed
Feb 3, 2025
junchichen21
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw many changes both in the source codes and test codes due to employing the newer version of package AtomsBase 0.5
. From my perspectives, these changes make the code more readable. Good work!
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use AtomsBase 0.5
This pull request includes significant changes to the
AbstractWalkers
andEnergyEval
modules, focusing on updating functions to use new methods for handling atomic systems and periodic boundary conditions. The changes also include improvements to the handling of atomic symbols and positions within various helper functions.Main changes in AtomsBase:
Periodic()
andDirichletZero()
boundary conditions are deprecated. Simple booleans are used now.atomic_symbol()
and other similar functions now need the atom index in the particles list to work.atomic_system()
is now the easiest way to construct a flexible system.boundary_conditions
andbounding_box
are no longer fields of a system, they are nowperiodicity
andcell_vectors
, respectively.Now using up-to-date
ExtXYZ
andAtomsIO
packages as well, as they are changed to accommodateAtomsBase
0.5.No breaking changes in the exported method, although some output now looks different.
Resolves #89.
Key Changes:
AbstractWalkers Module:
src/AbstractWalkers/AbstractWalkers.jl
: Added exports for new helper functionssort_components_by_atomic_number
,split_components
,split_components_by_chemical_species
, andcheck_num_components
.src/AbstractWalkers/atomistic_walkers.jl
: UpdatedAtomWalker
to use list comprehensions for extracting atomic symbols and positions, improving the handling of frozen species. [1] [2]src/AbstractWalkers/helpers.jl
: Refactoredsplit_components
andsplit_components_by_chemical_species
to use new methods for creatingFastSystem
objects. [1] [2]src/AbstractWalkers/helpers.jl
: Updatedsort_components_by_atomic_number
to use new methods for handling atomic symbols and positions, ensuring proper sorting and merging of species. [1] [2]EnergyEval Module:
src/EnergyEval/EnergyEval.jl
: Removed exports forsort_components_by_atomic_number
andsplit_components
, as these functions are now handled within theAbstractWalkers
module.src/EnergyEval/atomistic_energies.jl
: Refactoredpbc_dist
to useperiodicity
andcell_vectors
methods for boundary conditions and box dimensions.FreeBirdIO Module:
src/FreeBirdIO/FreeBirdIO.jl
: Updatedset_pbc
to use a simplified method for setting periodic boundary conditions.src/FreeBirdIO/FreeBirdIO.jl
: Refactoredappend_system
andextract_free_par
to use new methods for handling atomic systems and periodicity. [1] [2]src/FreeBirdIO/FreeBirdIO.jl
: Updatedgenerate_random_starting_config
andgenerate_multi_type_random_starting_config
to use new methods for setting boundary conditions and creating atomic systems. [1] [2]Tests:
test/test-AbstractWalkers.jl
: Updated tests to verify the new methods for handling cell vectors and periodicity in atomic systems. [1] [2] [3]test/test-EnergyEval.jl
: Updated tests forpbc_dist
to use the new methods for setting non-periodic boundary conditions.Documentation preview: https://wexlergroup.github.io/FreeBird.jl/previews/PR90/