Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling Scheme Routine Never Triger #84

Closed
junchichen21 opened this issue Jan 7, 2025 · 1 comment · Fixed by #90
Closed

Sampling Scheme Routine Never Triger #84

junchichen21 opened this issue Jan 7, 2025 · 1 comment · Fixed by #90

Comments

@junchichen21
Copy link
Collaborator

FreeBird.jl/src/SamplingSchemes/nested_sampling.jl

Line 172 in e597ff5

error("Unsupported MCRoutine type: $mc_routine")

This is not possible to happen, as it will error out during the function call.
@yangmr04 yangmr04 linked a pull request Feb 3, 2025 that will close this issue
Feature/update-AtomsBase-0.5 #90
Merged
@yangmr04
Copy link
Collaborator

yangmr04 commented Feb 3, 2025

Fixed in #90. It's now removed. Indeed, there is no other boolean option besides true or false.

@yangmr04 yangmr04 closed this as completed Feb 3, 2025
@yangmr04 yangmr04 mentioned this issue Feb 3, 2025
Merged
yangmr04 referenced this issue Feb 3, 2025
@yangmr04
chore: bump version to 0.0.3 in Project.toml
2e51297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/update-AtomsBase-0.5 wexlergroup/FreeBird.jl
2 participants
@yangmr04 @junchichen21