Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow detection of hardhat when using bun #4224

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

roderik
Copy link
Contributor

@roderik roderik commented Aug 26, 2024

  • added the user agent check now that bun supports it when finding the package manager
  • since bun does not have an ls command similar to the others, we check all installed packaged (--all is needed in monorepos) and check it it contains hardhat
  • if it cannot detect bun, it uses npm and if confronted with the bun package format it dies with invalid: "workspace:*" from apps/xxx
  • i only had this on the ci where i have npm and bun, not pnpm as i have locally and globally too, locally it works because it does not by default accepts global Bun but does accept a global pnpm.

ps: getTypeofLockFile does not work in a monorepo, as it just checks the cwd and not up in the tree

- added the user agent check now that bun supports it when finding the package manager
- since bun does not have an ls command similar to the others, we check all installed packaged (--all is needed in monorepos) and check it it contains hardhat
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: c658b59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wagmi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 4:01pm

@tmm tmm merged commit b0eb89c into wevm:main Sep 16, 2024
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants