Fix issue in CLI where the Foundry & Hardhat exclude patterns were ignored #4112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glob pattern forwarded to
fdir
was incorrect. It used:["patternA", "!patternB", "!patternC"]
, which matchespatternA
, or anything that does not matchpatternB
, or anything that does not matchpatternC
. So when we were expecting to get anything that matchespatternA
, excludingpatternB
andpatternC
, it basically allowed any file (and ironically, the bigger theexclude
list, the higher the probability of it including anything).This PR solves that.
It should fix #4107, as well as older issues like #3752 and #1815.