Add deleteSet and difference operations #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundnoble
force-pushed
the
push-kunxlzvyouzn
branch
2 times, most recently
from
72e45b5 to
25a65ae
Compare
These operations allow for efficient deletes from an IxSet.
edmundnoble
force-pushed
the
push-kunxlzvyouzn
branch
from
25a65ae to
8b3227c
Compare
adamgundry
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Thanks for proposing this! I'm also using ixset-typed in a way that would benefit from efficient (filtering and) deletion.
I notice that Data.IxSet.Typed.Ix.deleteSet is at least linear in the size of the map (i.e. the number of distinct keys), and Data.IxSet.typed.difference ignores the index maps. Couldn't we use the index maps to know which specific keys contain elements being deleted, and thereby have something more efficient, in particular in the case of large-ixset \\ small-ixset?
Also, it seems there isn't a filter operation yet, but presumably one add it along the lines of this PR?
cc @kosmikus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operations allow efficient deletes from an IxSet. These are often useful to filter an IxSet in a way that doesn't require rebuilding indices.