Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): optimize CSI sanity speed during CI #438

Open
wants to merge 1 commit into
base: sergey/configurable-wait-for-fs-deletion
Choose a base branch
from

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Jan 28, 2025

TL;DR

Removed -ginkgo.poll-progress-after 3s flag from CSI sanity test configurations

What changed?

Removed the polling progress flag from all test functions in the CSI sanity test script, including:

  • directory_volume_no_snapshots
  • directory_volume_and_snapshots
  • snaphot_volumes_with_2nd_level_shapshots
  • filesystem_volumes

How to test?

  1. Run the CSI sanity tests using the updated script
  2. Verify all test scenarios complete successfully:
    • Directory volume tests without snapshots
    • Directory volume tests with snapshots
    • Snapshot volume tests with second-level snapshots
    • Filesystem volume tests

Why make this change?

The polling progress flag was adding unnecessary overhead to the test execution without providing additional value. Removing it streamlines the test process while maintaining the same level of test coverage and validation.

Copy link

graphite-app bot commented Jan 28, 2025

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (01/28/25)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI/CD and release workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant