Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interactions between On-Disk Files and In-Memory Archives #160

Open
wants to merge 38 commits into
base: development
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
290c512
add method for unzipping in-memory archive to disk
WowbaggersLiquidLunch Mar 21, 2020
2b9b0d7
add tests for the new method that unzips in-memory archive to disk un…
WowbaggersLiquidLunch Mar 21, 2020
1211d20
refactor unzipItem(at:to:skipCRC32:progress:preferredEncoding:) to ca…
WowbaggersLiquidLunch Mar 21, 2020
57e4ace
add missing check of destinationURL for unzipItem(at:to:skipCRC32:pro…
WowbaggersLiquidLunch Mar 21, 2020
3895b23
add test testUnzipArchiveErrorConditions(); it fails at archive(for:m…
WowbaggersLiquidLunch Mar 21, 2020
355fcd5
fix documentation comment for unzip(_:destinationURL:skipCRC32:progre…
WowbaggersLiquidLunch Mar 21, 2020
96f30bf
add a method for zipping a file on disk to an archive that's not nece…
WowbaggersLiquidLunch Mar 21, 2020
4ca1827
add tests for the method that zips an item on disk to an archive that…
WowbaggersLiquidLunch Mar 21, 2020
b51417f
refactor zipItem(at sourceURL: URL, to destinationURL: URL) to call z…
WowbaggersLiquidLunch Mar 21, 2020
6e1f57d
catch up with upstream
WowbaggersLiquidLunch Mar 21, 2020
a2c866d
fix check for destinationURL
WowbaggersLiquidLunch Mar 21, 2020
792bbe5
add redundant check for sourceURL; otherwise test fails
WowbaggersLiquidLunch Mar 21, 2020
64caeba
let it pass if the destination is unwritable
WowbaggersLiquidLunch Mar 21, 2020
56a3e08
add test for in-memory archives if Swift >= 5.0
WowbaggersLiquidLunch Mar 21, 2020
8139ba6
add a method that zips an item and returns an archive
WowbaggersLiquidLunch Mar 21, 2020
9709030
add documentation comment for itemZipped(from:shouldKeepParent:compre…
WowbaggersLiquidLunch Mar 21, 2020
a945a2c
add 2 test for itemZipped(from:shouldKeepParent:compressionMethod:pro…
WowbaggersLiquidLunch Mar 21, 2020
6ea94c4
add test resources
WowbaggersLiquidLunch Mar 21, 2020
43d5e50
styling fix
WowbaggersLiquidLunch Jun 16, 2020
577f785
enable parallel and randomly ordered testing
WowbaggersLiquidLunch Jun 16, 2020
1e80409
create test plan from existing scheme
WowbaggersLiquidLunch Jun 16, 2020
8aa94ad
enable sanitisers and random test ordering
WowbaggersLiquidLunch Jun 16, 2020
318b14c
reorder test plan relative to other test files
WowbaggersLiquidLunch Jun 16, 2020
f216f18
more styling changes
WowbaggersLiquidLunch Jun 16, 2020
2b15e78
expand and update test platforms
WowbaggersLiquidLunch Jun 16, 2020
f96932b
move matrix strategy declaration inside each Linux job
WowbaggersLiquidLunch Jun 16, 2020
cdaf215
rename job Swift_latest to Linux_Swift_latest
WowbaggersLiquidLunch Jun 16, 2020
69f2e27
use guard on archive unwrapping in itemAipped(from:shouldKeepParent:c…
WowbaggersLiquidLunch Jun 16, 2020
25f6033
Merge branch 'development' of https://github.com/WowbaggersLiquidLunc…
WowbaggersLiquidLunch Jun 16, 2020
a9f6e6b
use guard for unwrapping newly created empty in-memory archives for t…
WowbaggersLiquidLunch Jun 16, 2020
84c12f2
force-unwrap itemZipped(from:)'s return value in do-catch
WowbaggersLiquidLunch Jun 16, 2020
3e677e3
minor styling fix
WowbaggersLiquidLunch Jun 16, 2020
c633d75
Revert "Merge branch 'development' of https://github.com/WowbaggersLi…
WowbaggersLiquidLunch Jun 16, 2020
1c124f7
Revert "reorder test plan relative to other test files"
WowbaggersLiquidLunch Jun 16, 2020
2b39fdd
Revert "enable sanitisers and random test ordering"
WowbaggersLiquidLunch Jun 16, 2020
b5fe190
Revert "create test plan from existing scheme"
WowbaggersLiquidLunch Jun 16, 2020
ea955a4
Revert "enable parallel and randomly ordered testing"
WowbaggersLiquidLunch Jun 16, 2020
f471786
add 'return' after 'XCFail'
WowbaggersLiquidLunch Jun 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
let it pass if the destination is unwritable
WowbaggersLiquidLunch committed Mar 21, 2020

Verified

This commit was signed with the committer’s verified signature. The key has expired.
danny-avila Danny Avila
commit 64caeba9091ea593aa3d4e1d94718f5dd9faa0d2
1 change: 1 addition & 0 deletions Tests/ZIPFoundationTests/ZIPFoundationFileManagerTests.swift
100755 → 100644
Original file line number Diff line number Diff line change
@@ -281,6 +281,7 @@ extension ZIPFoundationTests {
try fileManager.unzip(archive, to: unwritableURL)
XCTFail("Error when unzipping to unwritable destination not raised.")
} catch let error as Archive.ArchiveError { XCTAssert(error == .unwritableArchive)
} catch CocoaError.fileWriteNoPermission {
} catch { XCTFail("Unexpected error while trying to unzip via fileManager.") }
}