move module to concerns; use inject instead of reduce

weedySeaDragon · Dec 27, 2019 · 9729409 · 9729409
1 parent 0e46080
commit 9729409
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/app/models/ordered_ancestry_entry.rb → ...models/concerns/ordered_ancestry_entry.rb b/app/models/ordered_ancestry_entry.rb → ...models/concerns/ordered_ancestry_entry.rb
@@ -3,7 +3,7 @@
 
 #--------------------------
 #
-# @module OrderedNestedListEntry
+# @module OrderedAncestryEntry
 #
 # @desc Responsibility: Abstract class for objects with _ordered_ nested
 # descendents using the ancestry gem.``

diff --git a/app/models/user_checklist.rb b/app/models/user_checklist.rb
@@ -50,7 +50,7 @@ def self.not_completed_by_user(user)
   # --------------------------------------------------------------------------
 
   def completed?
-    !date_completed.blank? && descendants.reduce(:true) { |is_completed, descendant| descendant.completed? && is_completed }
+    !date_completed.blank? && descendants.inject(:true) { |is_completed, descendant| descendant.completed? && is_completed }
   end
 
 

diff --git a/spec/models/ordered_ancestry_entry_spec.rb → ...s/concerns/ordered_ancestry_entry_spec.rb b/spec/models/ordered_ancestry_entry_spec.rb → ...s/concerns/ordered_ancestry_entry_spec.rb
diff --git a/spec/models/user_checklist_spec.rb b/spec/models/user_checklist_spec.rb
@@ -79,7 +79,7 @@
       user_1 = checklist_1.user
       2.times { create(:user_checklist, :completed, user: user_1) }
 
-      checklist_last = create(:user_checklist, :completed)
+      create(:user_checklist, :completed)
 
       expect(described_class.completed_by_user(user_1).count).to eq 3
     end