Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unbuild plugin #435

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add unbuild plugin #435

merged 2 commits into from
Jan 8, 2024

Conversation

uncenter
Copy link
Contributor

@uncenter uncenter commented Jan 7, 2024

Adds a plugin for unbuild. This is a super simple plugin since AFAIK there isn't any other dependencies you can use with unbuild... is there a simpler way to ignore unbuild config files automatically? Is it worth having this as a plugin?

Copy link

vercel bot commented Jan 7, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @webpro on Vercel.

@webpro first needs to authorize it.

Copy link
Collaborator

@webpro webpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uncenter! I have a few comments. I'm missing some tests, any chance you could add those as well?

I think it's definitely worth adding as a plugin, since unbuild configuration defines custom entry files.

@uncenter
Copy link
Contributor Author

uncenter commented Jan 8, 2024

Tried my best to add those suggestions. Really not sure how to get these tests to run... I've installed everything, I've run the build commands... things just aren't working on my end.

@webpro webpro merged commit d9d48d5 into webpro-nl:main Jan 8, 2024
0 of 10 checks passed
@webpro
Copy link
Collaborator

webpro commented Jan 8, 2024

Sorry, somehow I assumed that you wanted me to wrap it up, that's why I merged it.

But I can still ask: what's not working? Or would you like me to finish this one?

@uncenter
Copy link
Contributor Author

uncenter commented Jan 8, 2024

Ah yeah I was very confused! Didn't mean to imply this was ready yet, I'm having trouble just running the tests in the first place on my end. If you can finish this one up that would be great, I don't think there is much more to be done except update the test to have a single entry that matches what is in the fixtures example config. Apologies for the miscommunication.

@webpro
Copy link
Collaborator

webpro commented Jan 8, 2024

Looks like the src/... import was an issue (should be relative). Then npm run build && npm test from the packages/knip should run fine.

Anyway, I'm on it :)

@uncenter
Copy link
Contributor Author

uncenter commented Jan 8, 2024

Darn, VSCode failed me! Thank you though ahah.

@webpro
Copy link
Collaborator

webpro commented Jan 8, 2024

🚀 This pull request is included in v3.13.0. See Release 3.13.0 for release notes.

@webpro
Copy link
Collaborator

webpro commented Jan 8, 2024

There we go, thank you so much for implementing this!

@uncenter uncenter deleted the add-unbuild-plugin branch January 8, 2024 17:06
@webpro
Copy link
Collaborator

webpro commented Jan 16, 2024

🚀 This pull request is included in v4.0.0. See Release 4.0.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants