-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unbuild
plugin
#435
Add unbuild
plugin
#435
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @webpro on Vercel. @webpro first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @uncenter! I have a few comments. I'm missing some tests, any chance you could add those as well?
I think it's definitely worth adding as a plugin, since unbuild configuration defines custom entry files.
Tried my best to add those suggestions. Really not sure how to get these tests to run... I've installed everything, I've run the build commands... things just aren't working on my end. |
Sorry, somehow I assumed that you wanted me to wrap it up, that's why I merged it. But I can still ask: what's not working? Or would you like me to finish this one? |
Ah yeah I was very confused! Didn't mean to imply this was ready yet, I'm having trouble just running the tests in the first place on my end. If you can finish this one up that would be great, I don't think there is much more to be done except update the test to have a single entry that matches what is in the fixtures example config. Apologies for the miscommunication. |
Looks like the Anyway, I'm on it :) |
Darn, VSCode failed me! Thank you though ahah. |
🚀 This pull request is included in v3.13.0. See Release 3.13.0 for release notes. |
There we go, thank you so much for implementing this! |
🚀 This pull request is included in v4.0.0. See Release 4.0.0 for release notes. |
Adds a plugin for unbuild. This is a super simple plugin since AFAIK there isn't any other dependencies you can use with unbuild... is there a simpler way to ignore unbuild config files automatically? Is it worth having this as a plugin?