add nx command shorthand support

webpro-nl · Dec 29, 2024 · a1ee0ed · a1ee0ed
1 parent 9590b92
commit a1ee0ed
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/packages/knip/fixtures/plugins/nx/libs/b/project.json b/packages/knip/fixtures/plugins/nx/libs/b/project.json
@@ -25,6 +25,9 @@
     },
     "tsc": {
       "executor": "./tools/executors/tsc:tsc"
+    },
+    "lint": {
+      "command": "biome lint ."
     }
   }
 }
diff --git a/packages/knip/src/plugins/nx/index.ts b/packages/knip/src/plugins/nx/index.ts
@@ -55,8 +55,13 @@ const resolveConfig: ResolveConfig<NxProjectConfiguration | NxConfigRoot> = asyn
     .map(executor => executor?.split(':')[0]);
 
   const scripts = targets
-    .filter(target => target.executor === 'nx:run-commands')
-    .flatMap(target => target.options?.commands ?? (target.options?.command ? [target.options.command] : []));
+    .filter(target => target.executor === 'nx:run-commands' || target.command)
+    .flatMap(target => {
+      if (target.command) return [target.command];
+      if (target.options?.command) return [target.options.command];
+      if (target.options?.commands) return target.options.commands;
+      return [];
+    });
 
   const inputs = options.getInputsFromScripts(scripts);
 

diff --git a/packages/knip/src/plugins/nx/types.ts b/packages/knip/src/plugins/nx/types.ts
@@ -1,6 +1,7 @@
 export interface NxProjectConfiguration {
   targets?: {
     [targetName: string]: {
+      command?: string;
       executor?: string;
       options?: {
         command?: string;

diff --git a/packages/knip/test/plugins/nx.test.ts b/packages/knip/test/plugins/nx.test.ts
@@ -26,10 +26,11 @@ test('Find dependencies with the Nx plugin', async () => {
   assert(issues.binaries['package.json']['nx']);
   assert(issues.binaries['libs/b/project.json']['webpack']);
   assert(issues.binaries['libs/b/project.json']['compodoc']);
+  assert(issues.binaries['libs/b/project.json']['biome']);
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    binaries: 4,
+    binaries: 5,
     devDependencies: 6,
     unlisted: 3,
     processed: 0,