Skip to content

Commit

Permalink
feat: support commitlint plugins key (#587)
Browse files Browse the repository at this point in the history
  • Loading branch information
beaussan authored Apr 7, 2024
1 parent 770f658 commit 9b4e0d9
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": ["@commitlint/config-conventional"] }
{ "extends": ["@commitlint/config-conventional"], "plugins": ["commitlint-plugin-tense"] }
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = { extends: ['@commitlint/config-conventional'] };
module.exports = { extends: ['@commitlint/config-conventional'], plugins: ['commitlint-plugin-tense'] };
3 changes: 2 additions & 1 deletion packages/knip/fixtures/plugins/commitlint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"commitlint": {
"extends": [
"@commitlint/config-conventional"
]
],
"plugins": ["commitlint-plugin-tense"]
}
}
5 changes: 4 additions & 1 deletion packages/knip/src/plugins/commitlint/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type { Plugin, ResolveConfig, IsPluginEnabled } from '#p/types/plugins.js

type CommitLintConfig = {
extends: string[];
plugins: string[];
};

const title = 'commitlint';
Expand All @@ -22,7 +23,9 @@ const config = [
];

const resolveConfig: ResolveConfig<CommitLintConfig> = config => {
return config.extends ? [config.extends].flat() : [];
const extendsConfigs = config.extends ? [config.extends].flat() : [];
const plugins = config.plugins ? [config.plugins].flat() : [];
return [...extendsConfigs, ...plugins];
};

export default {
Expand Down
5 changes: 4 additions & 1 deletion packages/knip/test/plugins/commitlint.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,14 @@ test('Find dependencies with the Commitizen plugin', async () => {
assert(issues.unlisted['.commitlintrc.json']['@commitlint/config-conventional']);
assert(issues.unlisted['commitlint.config.js']['@commitlint/config-conventional']);
assert(issues.unlisted['package.json']['@commitlint/config-conventional']);
assert(issues.unlisted['.commitlintrc.json']['commitlint-plugin-tense']);
assert(issues.unlisted['commitlint.config.js']['commitlint-plugin-tense']);
assert(issues.unlisted['package.json']['commitlint-plugin-tense']);

assert.deepEqual(counters, {
...baseCounters,
devDependencies: 1,
unlisted: 3,
unlisted: 6,
processed: 1,
total: 1,
});
Expand Down

0 comments on commit 9b4e0d9

Please sign in to comment.