Add support for destructuring pattern on member access of (re)exporte…

…d symbol

packages/knip/fixtures/re-exports-ns-member/index.ts

@@ -0,0 +1,5 @@
+import * as NS from './sub3';
+
+const { memberA, memberB } = NS.sub;
+
+const { memberC, memberD } = NS.pseudo;

packages/knip/fixtures/re-exports-ns-member/member-ab.ts

@@ -0,0 +1,2 @@
+export const memberA = 1;
+export const memberB = 1;

packages/knip/fixtures/re-exports-ns-member/member-cd.ts

@@ -0,0 +1,2 @@
+export const memberC = 1;
+export const memberD = 1;

packages/knip/fixtures/re-exports-ns-member/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "@fixtures/re-exports-ns-member"
+}

packages/knip/fixtures/re-exports-ns-member/sub1.ts

@@ -0,0 +1,2 @@
+export * from './member-ab';
+export * from './member-cd';

packages/knip/fixtures/re-exports-ns-member/sub2.ts

@@ -0,0 +1,4 @@
+export * as sub from './sub1';
+
+import * as pseudo from './sub1';
+export { pseudo };

packages/knip/fixtures/re-exports-ns-member/sub3.ts

@@ -0,0 +1 @@
+export * from './sub2';

packages/knip/fixtures/workspaces-pnpm/apps/a/index.ts

@@ -1,5 +1,5 @@
-import defaultA, { usedExportFromLibA } from '@scoped/lib-a';
-import defaultB, { usedExportFromLibB } from '@scoped/lib-b';
+import defaultA, { usedExportFromLibA } from '@workspaces-pnpm/lib-a';
+import defaultB, { usedExportFromLibB } from '@workspaces-pnpm/lib-b';
 import { c } from 'unlisted';
 
 defaultA;

packages/knip/src/typescript/getImportsAndExports.ts

@@ -298,17 +298,29 @@ const getImportsAndExports = (
         const symbol = sourceFile.locals?.get(String(node.escapedText));
         if (symbol) {
           if (importedInternalSymbols.has(symbol)) {
-            let members: string[] = [];
-            let current: ts.Node = node.parent;
-            while (current) {
-              const ms = getMemberStringLiterals(typeChecker, current);
-              if (!ms) break;
-              members = members.concat(
-                ms.flatMap(id => (members.length === 0 ? id : members.map(ns => `${ns}.${id}`)))
-              );
-              current = current.parent;
+            if (
+              ts.isVariableDeclarationList(node.parent.parent.parent) &&
+              ts.isVariableDeclaration(node.parent.parent) &&
+              ts.isObjectBindingPattern(node.parent.parent.name) &&
+              ts.isPropertyAccessExpression(node.parent)
+            ) {
+              const ns = String(symbol.escapedName);
+              const key = String(node.parent.name.escapedText);
+              const members = node.parent.parent.name.elements.map(element => `${key}.${element.name.getText()}`);
+              maybeAddAccessExpressionAsNsImport(ns, key);
+              maybeAddAccessExpressionAsNsImport(ns, members);
+            } else {
+              let members: string[] = [];
+              let current: ts.Node = node.parent;
+              while (current) {
+                const ms = getMemberStringLiterals(typeChecker, current);
+                if (!ms) break;
+                const joinIds = (id: string) => (members.length === 0 ? id : members.map(ns => `${ns}.${id}`));
+                members = members.concat(ms.flatMap(joinIds));
+                current = current.parent;
+              }
+              maybeAddAccessExpressionAsNsImport(String(node.escapedText), members);
             }
-            maybeAddAccessExpressionAsNsImport(String(node.escapedText), members);
           }
         }
       } else if (
@@ -331,7 +343,7 @@ const getImportsAndExports = (
           if (symbol) {
             const importedSymbolFilePath = importedInternalSymbols.get(symbol);
             if (importedSymbolFilePath) {
-              const members = node.parent.name.elements.flatMap(decl => decl.name.getText());
+              const members = node.parent.name.elements.map(element => element.name.getText());
               maybeAddAccessExpressionAsNsImport(String(node.escapedText), members);
             }
           }

packages/knip/test/re-exports-ns-member.test.ts

@@ -0,0 +1,21 @@
+import { test } from 'bun:test';
+import assert from 'node:assert/strict';
+import { main } from '../src/index.js';
+import { resolve } from '../src/util/path.js';
+import baseArguments from './helpers/baseArguments.js';
+import baseCounters from './helpers/baseCounters.js';
+
+const cwd = resolve('fixtures/re-exports-ns-member');
+
+test('Find destructured props of member-accessed imported symbol', async () => {
+  const { counters } = await main({
+    ...baseArguments,
+    cwd,
+  });
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    processed: 6,
+    total: 6,
+  });
+});