Don't return null for vitest environment (fixes #575)

webpro-nl · Mar 27, 2024 · 141b701 · 141b701
1 parent aa19491
commit 141b701
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/packages/knip/fixtures/workspaces-plugin-config/packages/backend/config/vitest.config.ts b/packages/knip/fixtures/workspaces-plugin-config/packages/backend/config/vitest.config.ts
@@ -3,6 +3,6 @@ import { defineConfig } from 'vitest/config';
 export default defineConfig({
   test: {
     include: ['**/*.vitest.ts'],
-    environment: 'happy-dom',
+    environment: 'node',
   },
 });
diff --git a/packages/knip/fixtures/workspaces-plugin-config/packages/backend/package.json b/packages/knip/fixtures/workspaces-plugin-config/packages/backend/package.json
@@ -6,7 +6,6 @@
   "devDependencies": {
     "eslint-plugin-no-secrets": "*",
     "eslint-plugin-prettier": "*",
-    "happy-dom": "*",
     "vitest": "^0.34.6"
   }
 }
diff --git a/packages/knip/src/plugins/vitest/helpers.ts b/packages/knip/src/plugins/vitest/helpers.ts
@@ -7,7 +7,6 @@ import type { ViteConfig } from './types.js';
  */
 
 type BuiltinEnvironment = 'node' | 'jsdom' | 'happy-dom' | 'edge-runtime';
-type VitestEnvironment = BuiltinEnvironment | (string & Record<never, never>);
 
 const environments = {
   node: null,
@@ -22,10 +21,8 @@ const envPackageNames: Record<Exclude<keyof typeof environments, 'node'>, string
   'edge-runtime': '@edge-runtime/vm',
 };
 
-export const getEnvPackageName = (env: VitestEnvironment) => {
-  if (env === 'node') return null;
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  if (env in envPackageNames) return (envPackageNames as any)[env];
+export const getEnvPackageName = (env: string) => {
+  if (env in envPackageNames) return envPackageNames[env as Exclude<BuiltinEnvironment, 'node'>];
   return `vitest-environment-${env}`;
 };
 

diff --git a/packages/knip/src/plugins/vitest/index.ts b/packages/knip/src/plugins/vitest/index.ts
@@ -42,7 +42,8 @@ const findConfigDependencies = (localConfig: ViteConfig, options: PluginOptions)
 
   if (!testConfig) return [];
 
-  const environments = testConfig.environment ? [getEnvPackageName(testConfig.environment)] : [];
+  const environments =
+    testConfig.environment && testConfig.environment !== 'node' ? [getEnvPackageName(testConfig.environment)] : [];
   const reporters = getExternalReporters(testConfig.reporters);
 
   const hasCoverageEnabled =