Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use methods to get client entries #5308

Merged

Conversation

LingyuCoder
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

A test case was added in test/e2e/client.test.js to test that the override can take effect correctly.

Motivation / Use-Case

Use methods to get client entries, so that users can introduce custom client entries instead by overriding these methods.

Breaking Changes

No breaking changes

Additional Info

Copy link

linux-foundation-easycla bot commented Sep 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

lib/Server.js Outdated Show resolved Hide resolved
lib/Server.js Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (af6bd68) to head (1642bb5).
Report is 91 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5308      +/-   ##
==========================================
- Coverage   90.29%   85.12%   -5.18%     
==========================================
  Files          15       16       +1     
  Lines        1577     1741     +164     
  Branches      601      652      +51     
==========================================
+ Hits         1424     1482      +58     
- Misses        140      233      +93     
- Partials       13       26      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit dc642a8 into webpack:master Sep 26, 2024
40 of 41 checks passed
@alexander-akait
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants