Remove weird, superfluous type hedging on IonicComponent selector

webful-ltd · Aug 25, 2024 · 39bd20f · 39bd20f
1 parent b1f0457
commit 39bd20f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/e2e/src/helpers/ionic-component.ts b/e2e/src/helpers/ionic-component.ts
@@ -1,15 +1,11 @@
 export class IonicComponent {
-  constructor(public selector: string | WebdriverIO.Element) {
+  constructor(public selector: string) {
   }
 
   get $() {
     return async ({ IonicPage }) => {
-      if (typeof this.selector === 'string') {
-        const activePage = await IonicPage.active();
-        return activePage.$(this.selector);
-      }
-
-      return this.selector;
+      const activePage = await IonicPage.active();
+      return activePage.$(this.selector);
     };
   }
 }
diff --git a/e2e/src/helpers/ionic-input.ts b/e2e/src/helpers/ionic-input.ts
@@ -11,7 +11,7 @@ export class IonicInput extends IonicComponent {
     value: string,
     { visibilityTimeout = 5000 }: ElementActionOptions = {}
   ) {
-    const el = await Ionic$.$(this.selector as string);
+    const el = await Ionic$.$(this.selector);
     await el.waitForDisplayed({ timeout: visibilityTimeout });
 
     const ionTags = ['ion-input', 'ion-textarea'];
@@ -24,7 +24,7 @@ export class IonicInput extends IonicComponent {
   }
 
   async getValue({ visibilityTimeout = 5000 }: ElementActionOptions = {}) {
-    const el = await Ionic$.$(this.selector as string);
+    const el = await Ionic$.$(this.selector);
     await el.waitForDisplayed({ timeout: visibilityTimeout });
 
     const ionTags = ['ion-input', 'ion-textarea'];