Prevent document from scrolling in customizable select popover #49104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing up or down on the first or last option of a customizable select should not let the document scroll. This was happening because the default event handler of the option was not handling the default if there was no option to focus in this keyboard event handler, but by setting the default as handled anyway this bug goes away. This was identified here: openui/open-ui#1087 (comment) Change-Id: I56ab094f468df1ef4847011763e20ea7e759d3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006515 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Traian Captan <tcaptan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1381284}
wpt-pr-bot
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing up or down on the first or last option of a customizable select
should not let the document scroll. This was happening because the
default event handler of the option was not handling the default if
there was no option to focus in this keyboard event handler, but by
setting the default as handled anyway this bug goes away. This was
identified here:
openui/open-ui#1087 (comment)
Change-Id: I56ab094f468df1ef4847011763e20ea7e759d3f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006515
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1381284}