[flex] Don't apply transferred min/max sizes. #48452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://chromium.googlesource.com/chromium/src/+/f357fe9f912bd1723fb73fdb693c6825dae23390 ... introduced a change where we applied the transferred min/max sizes to the inline min/max sizes. This was unintentional. The spec is unclear on this situation (after checking with the spec author), so filed an issue here: w3c/csswg-drafts#10997 We may change back again, but at least this brings us in-line with other browsers for the moment. Fixed: 368562235 Change-Id: I6f353e7d2e1ef0e1077af2b3b76c5f42632cc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907910 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363796}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5907910
branch
from
beb830d
to
29bbde1
Compare
wpt-pr-bot
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://chromium.googlesource.com/chromium/src/+/f357fe9f912bd1723fb73fdb693c6825dae23390
... introduced a change where we applied the transferred min/max sizes
to the inline min/max sizes.
This was unintentional. The spec is unclear on this situation (after
checking with the spec author), so filed an issue here:
w3c/csswg-drafts#10997
We may change back again, but at least this brings us in-line with
other browsers for the moment.
Fixed: 368562235
Change-Id: I6f353e7d2e1ef0e1077af2b3b76c5f42632cc6b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907910
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1363796}