Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebCodec | AudioEncoder ] Test incorrectly assuming that a bitrate is too high #49634

Open
jyavenard opened this issue Dec 11, 2024 · 0 comments

Comments

@jyavenard
Copy link
Contributor

comment: 'Bit rate too big',
config: {
codec: 'opus',
sampleRate: 8000,
numberOfChannels: 2,
bitrate: 6e9,

The test checks that a bitrate of 6e9 is too big.

But the bitrate is a long long https://w3c.github.io/webcodecs/#dom-audioencoderconfig-bitrate ; and 6e9 fits in that range.

Either the test should be removed or the spec amended to make it a plain long instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants