Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No test coverage for anchor-center with safe/unsafe #49415

Open
Scony opened this issue Nov 28, 2024 · 1 comment
Open

No test coverage for anchor-center with safe/unsafe #49415

Scony opened this issue Nov 28, 2024 · 1 comment

Comments

@Scony
Copy link
Contributor

Scony commented Nov 28, 2024

As per my understanding of the spec, the safe and unsafe keywords should alter the behavior of anchor-center.
Assuming the above is true, we got no coverage for that.

IMO what we should do is to:

  1. clone the tests like:
    https://github.com/web-platform-tests/wpt/blob/master/css/css-anchor-position/anchor-center-htb-htb.html
    https://github.com/web-platform-tests/wpt/blob/master/css/css-anchor-position/anchor-center-htb-vrl.html
    https://github.com/web-platform-tests/wpt/blob/master/css/css-anchor-position/anchor-center-vrl-vrl.html
    https://github.com/web-platform-tests/wpt/blob/master/css/css-anchor-position/anchor-center-vrl-htb.html
  2. change align-self: anchor-center; to align-self: safe anchor-center;
  3. change justify-self: anchor-center; to justify-self: safe anchor-center;
  4. adjust expectations
  5. repeat 1-4 for unsafe

I'd do this myself, but I'm not 100% sure if I understand correctly how safe/unsafe should work in conjunction with anchor-center.

@nt1m
Copy link
Member

nt1m commented Nov 30, 2024

@fantasai @tabatkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants