Fix and mark scroll marker tests as passing.

scroll-marker-011-ref.html: Wrap each letter inside a span, to better match the tests, and add overflow:hidden as well, in case glyphs have negative bearing. column-scroll-marker-reattach-target-current.html now needs its own ref instead of piggy-backing on scroll-marker-011-ref.html column-scroll-marker-008.html: Wrap each letter inside a span, to better match the ref. scroll-marker-group-013-ref.html: Add a third column. Some fonts have negative left bearing, so that text from the third column may overflow into the second. Bug: 332396355 Change-Id: Ife972731809d95c547c6215ab86aea8b2b40913e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110413 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1399082}
web-platform-tests · Dec 20, 2024 · 27855e6 · 27855e6
1 parent bd74372
commit 27855e6
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 3 deletions.
diff --git a/css/css-overflow/column-scroll-marker-008.html b/css/css-overflow/column-scroll-marker-008.html
@@ -25,7 +25,7 @@
   }
 </style>
 <p>The word "PASS" should be seen below.</p>
-<div style="float:left;">PA</div>
+<div style="float:left;"><span>P</span><span>A</span></div>
 <div class="scroller">
   <div style="height:200px;"></div>
 </div>
diff --git a/css/css-overflow/column-scroll-marker-reattach-target-current-ref.html b/css/css-overflow/column-scroll-marker-reattach-target-current-ref.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<style>
+  * {
+    font-family: monospace;
+  }
+</style>
+<p>The word "PASS" should be seen below.</p>
+<div style="overflow:hidden;">
+  PASS
+</div>
diff --git a/css/css-overflow/column-scroll-marker-reattach-target-current.html b/css/css-overflow/column-scroll-marker-reattach-target-current.html
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <title>CSS Overflow Test: ::column::scroll-marker display type change on :target-current</title>
 <link rel="help" href="https://issues.chromium.org/issues/378726503">
-<link rel="match" href="scroll-marker-011-ref.html">
+<link rel="match" href="column-scroll-marker-reattach-target-current-ref.html">
 <style>
   * {
     font-family: monospace;

diff --git a/css/css-overflow/scroll-marker-011-ref.html b/css/css-overflow/scroll-marker-011-ref.html
@@ -5,4 +5,6 @@
   }
 </style>
 <p>The word "PASS" should be seen below.</p>
-PASS
+<div style="overflow:hidden;">
+  <span>P</span><span>A</span><span>S</span><span>S</span>
+</div>
diff --git a/css/css-overflow/scroll-marker-group-013-ref.html b/css/css-overflow/scroll-marker-group-013-ref.html
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
 <style>
   #scroller {
+    overflow: hidden;
     columns: 2;
     column-fill: auto;
     padding: 0;
@@ -37,4 +38,5 @@
   <legend>Legend</legend>
   <div style="break-before:column;">first</div>
   <div style="break-before:column;">second</div>
+  <div style="break-before:column;">third</div>
 </fieldset>