Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround for Linter err #3837

Merged
merged 4 commits into from
May 21, 2024
Merged

Temporary workaround for Linter err #3837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99d042c
Temporary workaround for linter err
KyleJu May 21, 2024
df646a3
Update Makefile
KyleJu May 21, 2024
93fc8a0
Update Makefile
KyleJu May 21, 2024
88acbb2
Update backfill.go
KyleJu May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,6 @@ linters-settings:
# See: https://github.com/web-platform-tests/wpt.fyi/blob/main/go.mod
replace-allow-list:
- launchpad.net/gocheck
errcheck:
# TODO: Remove following line when version 1.58.3 is released.
ignore: ""
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ go_lint: golint go_test_tag_lint

# TODO: run on /shared/, /util/, /webapp/, /webdriver/
golangci_lint: golangci-lint
golangci-lint cache clean
golangci-lint run ./api/...

go_test_tag_lint:
Expand Down
2 changes: 1 addition & 1 deletion api/query/cache/backfill/backfill.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (m *backfillMonitor) Stop() error {
return m.ProxyMonitor.Stop()
}

// nolint:ireturn // TODO: Fix ireturn lint error
// nolint:all // TODO: Fix ireturn lint error
func (*backfillIndex) Bind([]shared.TestRun, query.ConcreteQuery) (query.Plan, error) {
return nil, nil
}
Expand Down
Loading