Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround for Linter err #3837

Merged
merged 4 commits into from
May 21, 2024
Merged

Temporary workaround for Linter err #3837

merged 4 commits into from
May 21, 2024

Conversation

KyleJu
Copy link
Collaborator

@KyleJu KyleJu commented May 21, 2024

golangci/golangci-lint#4733. Fix linter failures temporarily

@KyleJu
Copy link
Collaborator Author

KyleJu commented May 21, 2024

I changed the line from nolint:ireturn to nolint:all. I suspect that the definition of ireturn has changed in golangci-lint 1.58.2

@KyleJu
Copy link
Collaborator Author

KyleJu commented May 21, 2024

Offline discussions: I will try pinning the version and see if that fixes it

@KyleJu KyleJu merged commit 70824f6 into main May 21, 2024
12 checks passed
@KyleJu KyleJu deleted the KyleJu-patch-1 branch May 21, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants