Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark compiler.compile as private method #9472

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

chenjiahan
Copy link
Member

Summary

compiler.compile is an internal low-level method and should not be used by Rspack users.

This PR removes compiler.compile from the documentation and marks it as @private.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 2635310
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bebe401976680008f82b2d
😎 Deploy Preview https://deploy-preview-9472--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 26, 2025
@chenjiahan chenjiahan enabled auto-merge (squash) February 26, 2025 07:14
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #9472 will not alter performance

Comparing compile_method_0226 (2635310) with main (912f2b3)

Summary

✅ 7 untouched benchmarks

@chenjiahan chenjiahan merged commit a04609d into main Feb 26, 2025
31 checks passed
@chenjiahan chenjiahan deleted the compile_method_0226 branch February 26, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants