Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle css with BOM #9467

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix: handle css with BOM #9467

merged 2 commits into from
Feb 26, 2025

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Feb 26, 2025

Summary

fix #9461

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Feb 26, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit fe9efda
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67be8d5abf405b00089f146e

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Feb 26, 2025
@chenjiahan chenjiahan requested a review from JSerFeng February 26, 2025 03:47
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #9467 will not alter performance

Comparing inottn:fix/css-with-bom (fe9efda) with main (9a6473c)

Summary

✅ 7 untouched benchmarks

h-a-n-a
h-a-n-a approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@h-a-n-a h-a-n-a merged commit 4508a5e into web-infra-dev:main Feb 26, 2025
27 checks passed
@inottn inottn deleted the fix/css-with-bom branch February 26, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: File encoded as UTF-8 with BOM makes output file invalid
2 participants
@inottn @h-a-n-a