[Bug]: incorrect type signatures on Hash's digest and update methods

[dinofx]

System Info

macOS

Details

The Hash class' digest and update methods are incorrect. They are ambiguous and should use overloads like the node type declarations do.

The existing signatures are:

rspack/packages/rspack/src/util/hash/index.ts

Lines 21 to 23 in 2d10e9a

	update(data: string | Buffer, inputEncoding?: string): this {
	throw new AbstractMethodError();
	}

rspack/packages/rspack/src/util/hash/index.ts

Lines 32 to 34 in 2d10e9a

	digest(encoding?: string): string | Buffer {
	throw new AbstractMethodError();
	}

Using overloaded signatures makes it clear when the inputEncoding is required, and when the return value will be a string vs. buffer. The correct signatures would be something like:

update(data: string, inputEncoding: string): this;
update(data: Buffer): this;
update(data: string | Buffer, inputEncoding?: string): this {
...

digest(): Buffer;
digest(encoding: string): string;
digest(encoding?: string): string | Buffer {
...

Reproduce link

No response

Reproduce Steps

In a loader, do something like:

const hash = this.utils.createHash('md5').update(buffer).digest('hex');

The call to update suggests that a second param can be passed, but this isn't true for buffers. And the type of hash above is ambiguously string | Buffer, when it is guaranteed to be string since an encoding was provided.