Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ocirepositories to nsaccess rules #4665

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Feb 1, 2025

Relates to #3702

What changed?

The primary change in this PR is to add ocirepositories to the source.toolkit.fluxcd.io in the required RBAC rules. This should be part of the requirements alongside the other Flux source types - as weave-gitops is able to list source resources. I did not add any requirement for access to the Flux API groups notification.toolkit.fluxcd.io or image.toolkit.fluxcd.io - even if I think it's strange that this is not a requirement.

I have also organized the required rules better:

  • Grouped by API group in list of requirements.
  • Fixed the semi-duplicated requirements for events.
  • Sorted resources in rules alphabetically.

Why was this change made?

Before starting on the simpler nsaccess checker suggested in #3702 (comment), I would like to correct the code currently used.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb requested a review from a team February 1, 2025 09:57
@erikgb erikgb merged commit bf9b879 into weaveworks:main Feb 1, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants