Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve python setup in nightly workflow #4619

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jan 25, 2025

Closes

What changed?

  • Create a pip requirements file to manage Python dependencies required for the nightly (Playwright) workflow.
  • Upgrade Python to 3.12 (not the latest, but pretty stable).
  • Introduce caching of pip dependencies in the workflow.

Why was this change made?

This change was triggered by alerts about unpinned dependencies from our security scanner. But I also believe this setup is cleaner and more performant (caching).

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb requested a review from casibbald January 25, 2025 11:22
@erikgb erikgb merged commit 5e22fca into weaveworks:main Jan 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants