-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI bootstrap flux documentation #4136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments and suggestions in #4137
website/docs/enterprise/getting-started/install-enterprise-cli.mdx
Outdated
Show resolved
Hide resolved
website/docs/enterprise/getting-started/install-enterprise-cli.mdx
Outdated
Show resolved
Hide resolved
website/docs/enterprise/getting-started/install-enterprise-cli.mdx
Outdated
Show resolved
Hide resolved
@@ -71,6 +70,9 @@ Please use the following command to start the installation wizard of Weave GitOp | |||
--version="0.35.0" \ | |||
--domain-type="localhost" \ | |||
--password="admin123" | |||
--repo-url="ssh://git@github.com/my-org-name/my-repo-name" | |||
--branch="main" | |||
--repo-path="clusters/my-cluster" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested whether you could bootstrap with this command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, i guess i meant before without the \
that i dont think it would work.
➜✗ gitops bootstrap \
--kubeconfig=$HOME/.kube/config \
--private-key=$HOME/.ssh/id_rsa \
--private-key-password="" \
--version="0.35.0" \
--domain-type="localhost" \
--password="admin123" \
--repo-url="ssh://git@github.com/my-org-name/my-repo-name" \
--branch="main" \
--repo-path="clusters/my-cluster"
► creating client to cluster
✔ created client to cluster: https://127.0.0.1:52179
◎ checking flux
► verifying flux installation
✔ flux is installed
7. [Access the dashboard](#access-the-dashboard): via the link from the installation success message. | ||
8. (Optional) [Configure OIDC](#configure-oidc): to enable login to dashboard via OIDC providers. | ||
2. (Optional) [Bootstrap Flux](#bootstrap-flux): bootstrap flux in case flux not found. | ||
3. [Verify Entitlement](#verifying-entitlement): verify the Entitlements secret content (username, password, entitlement). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels odd that we could be doing a mutation in the cluster like installing flux without first verifying entitlements (given that is a pre-requirement). how do you guys feel about this ( cc @MostafaMegahid @waleedhammam )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think when we discussed it before, there was a dependency as the entitlement lies in flux-system
namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean that given we have verifyXX as step, those seem better to come first before any action, as they are pre-conditions that we need to meet or we would drop. if we are in the scenario of dropping cause pre-condition is not met, you dont want to have done any change in the users environment
- verifies first then
- flux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review the suggestions in the PR https://github.com/weaveworks/weave-gitops/pull/4137/files i could see that flux
still not in Capital or typos like
Thanks for the suggestions. |
* some suggestion while reading the docs * some suggestions while reading the docs * moving from id_rsa to id_ed25519 in examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks you for adding the docs
Closes weaveworks/weave-gitops-enterprise#3619
Documentation Changes