feat: recommend settings for log viewer #487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces prompt to recommend changing the
autorun
andfollow
settings contributed by vscode-kubernetes.This adds a setting to vscode-gitops-tools for when the user presses
Never Show Again
so that we can persist their choice.It will show up in the following conditions:
This means, even if the
ignoreConfigRecommendations
setting is false, we still won't prompt the user if they happen to already have the setting we were going to recommend.Demo
When the user opens the log viewer, they get prompted to change the settings, this enables autorun. Because the settings now match what the user wants, they don't get the prompt again. 👍🏽
Screencast.from.2023-09-17.17-29-07.webm
When the user presses "Never Show Again", it changes the
ignoreConfigRecommendations
setting and the user will not be asked again. 👍🏽Screencast.from.2023-09-17.17-31-21.webm
Related