Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recommend settings for log viewer #487

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

SethFalco
Copy link
Contributor

Introduces prompt to recommend changing the autorun and follow settings contributed by vscode-kubernetes.

This adds a setting to vscode-gitops-tools for when the user presses Never Show Again so that we can persist their choice.

It will show up in the following conditions:

  • The user has not disabled setting recommendations.
  • The settings are not already what we want them to be.

This means, even if the ignoreConfigRecommendations setting is false, we still won't prompt the user if they happen to already have the setting we were going to recommend.

Demo

When the user opens the log viewer, they get prompted to change the settings, this enables autorun. Because the settings now match what the user wants, they don't get the prompt again. 👍🏽

Screencast.from.2023-09-17.17-29-07.webm

When the user presses "Never Show Again", it changes the ignoreConfigRecommendations setting and the user will not be asked again. 👍🏽

Screencast.from.2023-09-17.17-31-21.webm

Related

@kingdonb
Copy link
Collaborator

Amazing! Thanks for contributing this, we will take a look and see if we can get it into the next release 😄

@juozasg juozasg merged commit 6cb380e into weaveworks:main Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs formatting and UX improvements
3 participants