K8s client final release #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove refreshes from reconcile functions I think there is no need for these refreshes, this change is aimed at addressing weaveworks#450 If we have sent async reconciles to the resource, and all visible resources are in the informer's subscriptions, then I think we don't need to call refresh, we'll just get a call when it's needed. Signed-off-by: Kingdon Barrett <kingdon@weave.works> * remove unused code don't leave it hanging around in comments, it's not coming back Signed-off-by: Kingdon Barrett <kingdon@weave.works> --------- Signed-off-by: Kingdon Barrett <kingdon@weave.works>
kingdonb
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.