Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The extension is broken since December #503

Open
kingdonb opened this issue Jan 20, 2024 · 4 comments
Open

The extension is broken since December #503

kingdonb opened this issue Jan 20, 2024 · 4 comments
Milestone

Comments

@kingdonb
Copy link
Collaborator

kingdonb commented Jan 20, 2024

Expected behaviour

When 0.26.0 is used, it should not glitch out in the UI

Actual behaviour

Super glitch out in the UI if you're running VSCode editor version from November or later. If you're running the editor version 1.84.2, the extension 0.26.0 behavior is perfect. If you are upgraded to the latest 1.85.2 then you're totally hosed.

Steps to reproduce

See Sunkworks - Pt. 25 (Emerg. Maintenance) - youtube stream link

Versions

We are going to rollback to 0.24.3 behavior, as soon as we confirm that version still works with the 1.85.2+ vscode release.

Version 0.27.0 will have the old (not-live updated UI) behavior where users need to manually refresh in the UI.
Version 0.28.0 will have the new (live updated UI) behavior where users never need to click refresh, with no UI glitching.

I've moved some milestones around, we may have prereleases between 0.27 and 0.28 that expect you're on the old 1.84 editor so you can get the new behavior - but until we determine how to fix it, if the issue can be fixed here, or if we need to fix it upstream, there will be no release that has the live updated UI feature. Sorry for releasing this prematurely!

Will update this issue when the rollback is complete, so users can decide which version they want (and so new users coming to the extension for the first time are not presented with a broken release, when they haven't opted into any prerelease build.)

@kingdonb kingdonb added this to the 0.27.x milestone Jan 20, 2024
@kingdonb
Copy link
Collaborator Author

The PR in #504 did not get the job done, #505 is going out as a second try to the "prerelease" edge branch now.

I think this one worked. Git reset/checkout and revert with an edge branch in the middle is a bit harder than I remembered.

@kingdonb
Copy link
Collaborator Author

The rollback has been merged to main successfully. This means that our live update behavior is (temporarily) removed from the release.

In the mean time, if you're missing the live update function, you can pin VSCode to v1.84.2 and use v0.26.0 GitOps Tools.

(The v0.27.0 release which rolled back our live-update function is going out now, users should all be upgraded to it unless they are pinned to an older release/prerelease version.)

We will bring this feature back first in the prerelease channel, then as we vet it against different versions of VSCode, we may be able to promote it back to the main release again. We will not do any of that before v0.28.0 - patches in v0.27.0 will not bring back the live update behavior, but the prerelease channel might (should).

Hope this is clear for anyone that's still bearing with us using the extension! Sorry for the trouble, I hate asking people to pin themselves to a particular version, but we really can't avoid that since:

That issue is crippling and makes the extension completely unusable for the vast majority of users. Many are already pinning.

@kingdonb
Copy link
Collaborator Author

The v0.27.0 release is out, the upcoming bump in edge may happen today or it may happen later.

Recommend don't use the edge/prerelease branch for now unless you're also pinning vscode to the October 2023 release or earlier! It may take some time to isolate the changes needed to fix this issue. We haven't found a way to contact the VSCode team directly about their changes yet, (probably could open an issue there now, but would rather go in better informed...)

@kingdonb
Copy link
Collaborator Author

kingdonb commented Apr 9, 2024

There is a #flux-ecosystem channel on the CNCF slack that users can ask questions about the VSCode extension.

Today I acknowledged that development of the VSCode extension GitOps Tools has ceased, and there is no plan to work on v0.28.0 or future releases. This is my own opinion, anyone that is interested in further maintenance work for the VSCode extension is still welcome to talk to me about it. However, we did not budget time for this work given the shifting priorities.

It is not outside of the realm of possibilities that we would get new motivation to work on this. The redacted feature was really compelling, even if the private APIs got rugged by VSCode. I still wonder if there would be a way to implement this so it would not get broken, using public/ documented APIs instead of the ones that got rugged from under us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant