Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Add ADR on layering. #363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add ADR on layering. #363

wants to merge 2 commits into from

Conversation

bigkevmcd
Copy link
Contributor

Description

This is the ADR on layering.

Checklist

  • Added tests that cover your change
  • Added/modified documentation as required (such as the README.md (diagrams, usage, roadmap etc), and anything in examples/)
  • Made sure the title of the PR is a good description that can go into the release notes
  • Added a kind label to the PR (e.g. kind/feature)

Skarlso
Skarlso reviewed Nov 16, 2021
View reviewed changes
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, just have a couple questions to clarify.

Skarlso
Skarlso approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LGTM

@Skarlso
Copy link
Contributor

Skarlso commented Nov 16, 2021

Can you do an update and go mod tidy on your branch please? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Skarlso Skarlso Skarlso approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigkevmcd @Skarlso