Capi self filtering #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add currentClusterName to acd spec
…r name of cluster to be skipped Update capi sample acd to include currentClusterRef
bigkevmcd
requested changes
Dec 21, 2023
|
|
||
| // Current Cluster name indicating the management cluster | ||
| // used to avoid choosing the cluster the controller is running in | ||
| CurrentClusterRef Cluster `json:"currentClusterRef,omitempty"` |
There was a problem hiding this comment.
Should we add a CAPI field and configure this within that?
Given that we only use this for the CAPI Provider?
| // +required | ||
| Name string `json:"name"` | ||
| } | ||
|
|
There was a problem hiding this comment.
One idea here is to implement Stringer this way in CAPIProvider.ClusterID you could just call p.ManagementClusterRef.String() if/when Cluster grows a Namespace, that code remains the same?
… management cluster name Add String funct to Cluster to convert the CurrentClusterRef to string whenever needed
bigkevmcd
approved these changes
Dec 21, 2023
|
|
||
| // String returns the string representation of the Cluster | ||
| func (c Cluster) String() string { | ||
| return fmt.Sprintf("%v", c.Name) |
There was a problem hiding this comment.
Could just return c.Name ?
| @@ -45,6 +65,9 @@ type AutomatedClusterDiscoverySpec struct { | |||
| // AKS configures discovery of AKS clusters from Azure. | |||
| AKS *AKS `json:"aks,omitempty"` | |||
|
|
|||
| // CAPI configures discovery of CAPI clusters | |||
| CAPI *CAPI `json:"capi,omitempty"` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue weaveworks/weave-gitops-enterprise#3739
CurrentClusterRefto acd spec to include the current management clustermanagementClusterRefto capi