Add EKS (aws) ProviderCluster implementation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
requested changes
Nov 22, 2023
foot
reviewed
Dec 7, 2023
|
|
||
| var err error | ||
| clusters, clusterID := []*providers.ProviderCluster{}, "" | ||
| logger := log.FromContext(ctx).WithValues("name", cd.Name, "type", cd.Spec.Type) |
There was a problem hiding this comment.
Its already included, rm name
foot
reviewed
Dec 7, 2023
| tokenPrefix = "k8s-aws-v1." | ||
| tokenAgeMins = 15 | ||
| clusterNameHeader = "x-k8s-aws-id" | ||
| ) |
There was a problem hiding this comment.
Lift these to the top of the file or keep here?
foot
reviewed
Dec 11, 2023
| return azure.NewAzureProvider(acd.Spec.AKS.SubscriptionID), nil | ||
| } else if acd.Spec.Type == "eks" { | ||
| return aws.NewAWSProvider(acd.Spec.EKS.Region), nil | ||
| } |
There was a problem hiding this comment.
Be more defensive here to avoid a panic in case spec.EKS/spec.AKS is not present
bigkevmcd
force-pushed
the
eks
branch
4 times, most recently
from
100a572
to
d8c855f
Compare
bigkevmcd
force-pushed
the
eks
branch
5 times, most recently
from
2de16ca
to
df699dd
Compare
This adds support for validating that the configuration for EKS and AKS clusters is provided when the type is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for AWS EKS. That includes:
ListClusters: Retrieve EKS clusters and kubeconfigs.ClusterID: Returns unique cluster ID given its name.