From e6b43e77a2dfeab82e55159b78c7a0361e7d8579 Mon Sep 17 00:00:00 2001 From: mlenterman Date: Fri, 20 Dec 2024 11:45:08 +0100 Subject: [PATCH 1/3] test(unit): NNP matching statutory name but no innRechtsvorm should result in match --- ...oInnRechtsvormShouldResultInMatch.properties | 14 ++++++++++++++ .../MatchWithZdsRol.xml | 12 ++++++++++++ .../in.xml | 17 +++++++++++++++++ .../out.xml | 15 +++++++++++++++ 4 files changed, 58 insertions(+) create mode 100644 src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch.properties create mode 100644 src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/MatchWithZdsRol.xml create mode 100644 src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/in.xml create mode 100644 src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/out.xml diff --git a/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch.properties b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch.properties new file mode 100644 index 00000000..90b4bd68 --- /dev/null +++ b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch.properties @@ -0,0 +1,14 @@ +scenario.description: + +include: ../common.properties + +zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.className: nl.nn.adapterframework.testtool.XsltProviderListener +zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.filename: Translate/Common/xsl/SelectZdsRolesFromListWithMatchingIdentity.xslt + +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read: NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/in.xml +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param1.name: MatchWithZdsRol +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param1.valuefile: NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/MatchWithZdsRol.xml +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param1.type: domdoc +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param2.name: debug +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param2.value: false +step2.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.write: NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/out.xml diff --git a/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/MatchWithZdsRol.xml b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/MatchWithZdsRol.xml new file mode 100644 index 00000000..c4780457 --- /dev/null +++ b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/MatchWithZdsRol.xml @@ -0,0 +1,12 @@ + + + + Gemeente Súdwest-Fryslân + + + + 12345678 + + diff --git a/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/in.xml b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/in.xml new file mode 100644 index 00000000..f659fc3e --- /dev/null +++ b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/in.xml @@ -0,0 +1,17 @@ + + + + + Gemeente Súdwest-Fryslân + + + + different but no kerngegeven + + + diff --git a/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/out.xml b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/out.xml new file mode 100644 index 00000000..0f071b6c --- /dev/null +++ b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NNPWithMatchingStatutoryNameButNoInnRechtsvormShouldResultInMatch/out.xml @@ -0,0 +1,15 @@ + + + + + Gemeente Súdwest-Fryslân + + + + different but no kerngegeven + + + From c35fdde7c001ed42af399857f6cc57758bffc413 Mon Sep 17 00:00:00 2001 From: mlenterman Date: Fri, 20 Dec 2024 11:45:38 +0100 Subject: [PATCH 2/3] fix: matching a ZDS rol with ZGW roles only based on kerngegevens fails when one or more kerngegevens are absent on both sides --- ...tZdsRolesFromListWithMatchingIdentity.xslt | 45 ++++++++++++------- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/src/main/configurations/Translate/Common/xsl/SelectZdsRolesFromListWithMatchingIdentity.xslt b/src/main/configurations/Translate/Common/xsl/SelectZdsRolesFromListWithMatchingIdentity.xslt index a098f40b..501d7869 100644 --- a/src/main/configurations/Translate/Common/xsl/SelectZdsRolesFromListWithMatchingIdentity.xslt +++ b/src/main/configurations/Translate/Common/xsl/SelectZdsRolesFromListWithMatchingIdentity.xslt @@ -57,8 +57,10 @@ @@ -92,13 +94,20 @@ @@ -194,7 +208,8 @@ From f4d0d0f874cb204d81ab94749f5192c179d620bd Mon Sep 17 00:00:00 2001 From: mlenterman Date: Fri, 20 Dec 2024 15:38:02 +0100 Subject: [PATCH 3/3] test(unit): NPS testcase with one matching kerngegeven and other absent on both sides --- ...ngKerngegevensShouldResultInMatch.properties | 14 ++++++++++++++ .../MatchWithZdsRol.xml | 12 ++++++++++++ .../in.xml | 17 +++++++++++++++++ .../out.xml | 15 +++++++++++++++ 4 files changed, 58 insertions(+) create mode 100644 src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch.properties create mode 100644 src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/MatchWithZdsRol.xml create mode 100644 src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/in.xml create mode 100644 src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/out.xml diff --git a/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch.properties b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch.properties new file mode 100644 index 00000000..8f71e3d1 --- /dev/null +++ b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch.properties @@ -0,0 +1,14 @@ +scenario.description: + +include: ../common.properties + +zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.className: nl.nn.adapterframework.testtool.XsltProviderListener +zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.filename: Translate/Common/xsl/SelectZdsRolesFromListWithMatchingIdentity.xslt + +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read: NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/in.xml +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param1.name: MatchWithZdsRol +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param1.valuefile: NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/MatchWithZdsRol.xml +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param1.type: domdoc +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param2.name: debug +step1.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.read.param2.value: false +step2.zaakbrug.SelectZdsRolesFromListWithMatchingIdentity.write: NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/out.xml diff --git a/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/MatchWithZdsRol.xml b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/MatchWithZdsRol.xml new file mode 100644 index 00000000..905eefdd --- /dev/null +++ b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/MatchWithZdsRol.xml @@ -0,0 +1,12 @@ + + + + Precies + + + + 12345678 + + \ No newline at end of file diff --git a/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/in.xml b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/in.xml new file mode 100644 index 00000000..7e8665f0 --- /dev/null +++ b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/in.xml @@ -0,0 +1,17 @@ + + + + + Precies + + + + 12345678 + + + diff --git a/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/out.xml b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/out.xml new file mode 100644 index 00000000..63e5cb6b --- /dev/null +++ b/src/test/testtool/SelectZdsRolesFromListWithMatchingIdentity/NPSWithMatchingGeslachtsnaamButAbsentRemainingKerngegevensShouldResultInMatch/out.xml @@ -0,0 +1,15 @@ + + + + + Precies + + + + 12345678 + + +