Do not encode booleans with XMLEncoder #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ik vertrouw dit niet helemaal. Maar ik heb gezien dat het success checkpoint in mijn test nu "true" laat zien, geen XML code. Dat was tenminste zo een paar commits geleden. Sindsdien heb ik een paar dingen toegevoegd... |
nielsm5
requested changes
Sep 24, 2024
| @@ -48,6 +51,7 @@ | |||
| * @author Jaco de Groot | |||
| */ | |||
| public class MessageEncoderImpl implements MessageEncoder { | |||
| private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); | |||
There was a problem hiding this comment.
Dit is zonde, je weet immers de classname al...
| @@ -69,7 +73,10 @@ public ToStringResult toString(Object message, String charset) { | |||
| } else if (message instanceof String) { | |||
| toStringResult = new ToStringResult((String)message, null); | |||
| } else { | |||
| if (message instanceof byte[]) { | |||
| if (message instanceof Boolean) { | |||
| toStringResult = new ToStringResult(Boolean.toString((Boolean) message), null, Boolean.class.getName()); | |||
There was a problem hiding this comment.
Gewoon direct returnen toch?
Comment on lines
+160
to
+161
| Object rawResult = Boolean.valueOf(message); | ||
| return (T) rawResult; |
|
Dit ga ik niet afmaken. Hebben we toen uitgebreid over gepraat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.