Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconvinient feedback on wrong filter input #858

Open
jacodg opened this issue Dec 23, 2024 · 3 comments
Open

Inconvinient feedback on wrong filter input #858

jacodg opened this issue Dec 23, 2024 · 3 comments
Assignees
Labels
Frontend Something to be changed in frontend

Comments

@jacodg
Copy link
Contributor

jacodg commented Dec 23, 2024

image

In the old GUI:

image

In some cases the new GUI does it in a similar way, see #857

@MatthijsSmets
Copy link
Contributor

The toast is no longer hidden behind the filter side drawer, can you confirm @jacodg ?

@MatthijsSmets MatthijsSmets moved this from To do to Needs response in Ladybug Jan 21, 2025
@jacodg
Copy link
Contributor Author

jacodg commented Jan 27, 2025

It is now readable:

Image

But the message isn't as user friendly as with the old GUI:

Image

It feels like in some cases a low level is shown and in another case a more userfriendly message. Like in my initial comment: In some cases the new GUI does it in a similar way, see #857

@jacodg jacodg assigned MatthijsSmets and unassigned jacodg Jan 27, 2025
@jacodg
Copy link
Contributor Author

jacodg commented Jan 28, 2025

I understand from Matthijs that the error message in #857 was done by the client side validation code which has been removed (validation is now done on the backend). We will change the error on wrong filter input by the user to a warning toaster that will automatically disappear.

@jacodg jacodg assigned jacodg and unassigned MatthijsSmets Feb 7, 2025
@jacodg jacodg moved this from Needs response to In progress in Ladybug Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Something to be changed in frontend
Projects
Status: In progress
Development

No branches or pull requests

2 participants