Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review #205

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Code Review #205

wants to merge 11 commits into from

Conversation

joyce-paul
Copy link

Deliverable Submission
Please describe your comfort and completeness levels before submitting.
Comfort Level (1-5): 4
Completeness Level (1-5): 3.5
What did you think of this deliverable?: 3.5

Hi Rob, here are my suggested changes:
(1) Pokemon.jsx:

  • Amended top margin
  • Changed the colour of the button and its text size

(2) 404.jsx:

  • Increased size, changed the colour and margin

(3) delete.jsx:

  • Button : Changed colour and font size
  • Text field: Changed text colour and size

(4) Edit.jsx:

  • Headings: Changed colour
  • Text fields: Reduced font size

(5) Id.jsx:

  • Main heading: Increased size and colour
  • Added image
  • Other text: Increased size and colour

(6) New.jsx:

  • Changed margin a little
  • Increased font size
  • Changed colour to grey
  • Changed button colour to red and increased button size

Thanks,
Joyce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants