Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Packages in TestScanSyscollectorCases #4997

Conversation

rafabailon
Copy link
Member

@rafabailon rafabailon commented Feb 21, 2024

Description

Add package metadata to vuln_packages.json using results from Research vulnerability Packages used by E2E Vulnerability Detection tests #4943 and edit the cases used by the test.

Testing Performed

OS Wazuh Package Test Package
Windows 11 Agent NodeJS
CentOS 7 Agent OpenJDK
Ubuntu 22 Agent MySQL

Build: https://ci.wazuh.info/job/Test_e2e_system/243/

OS Result
Windows 11
CentOS 7
Ubuntu 22

@rafabailon rafabailon self-assigned this Feb 21, 2024
@rafabailon rafabailon linked an issue Feb 21, 2024 that may be closed by this pull request
@rafabailon rafabailon marked this pull request as draft February 21, 2024 14:41
@rafabailon rafabailon force-pushed the feature/4991-update-packages-in-TestScanSyscollectorCases branch from bfa9004 to a68f2cc Compare March 5, 2024 10:41
@rafabailon
Copy link
Member Author

Update

I have updated the branch and am trying to run the tests to analyze the results. I cannot use the pipeline due to the limitation in creating MacOS machines. I am trying to set up the necessary machines and launch the tests locally.

@rafabailon
Copy link
Member Author

rafabailon commented Mar 6, 2024

Update

I have launched the pipeline to build the machines necessary for the tests (except MacOS). I have run the tests locally. When using the testing framework (wazuh-qa) I had problems because, although I was using Python 3.11.6, when installing the requirements, it installed the wrong version of the py package.

py~=1.10.0; platform_system != "Windows" or python_version <= "3.10"

py==1.11.0; platform_system == "Windows" and python_version >= "3.11"

I have used an Ubuntu mv in version 23.10.

When running the tests, they have entered a loop since the script is not prepared to execute .msi files on Windows. I have to prepare a change to accept the new .msi installers.

I have launched a second run of the tests without Windows and these are the results: Linux_Test.zip

image

@rafabailon rafabailon force-pushed the feature/4991-update-packages-in-TestScanSyscollectorCases branch from caaee93 to 4120ae7 Compare March 6, 2024 17:01
@rafabailon rafabailon force-pushed the feature/4991-update-packages-in-TestScanSyscollectorCases branch from 4120ae7 to 9b4e3f6 Compare March 6, 2024 17:01
@rafabailon
Copy link
Member Author

rafabailon commented Mar 7, 2024

Update

You have launched the pipeline to create the testing environment. I have run the Windows tests.

image

These are the test results: windows_test.zip

@rafabailon rafabailon marked this pull request as ready for review March 7, 2024 11:24
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, but some changes are required

@juliamagan
Copy link
Member

In addition, we need to add an entry in the changelog

@rafabailon rafabailon force-pushed the feature/4991-update-packages-in-TestScanSyscollectorCases branch from 27622c4 to 6d11aea Compare March 8, 2024 09:02
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjiglesias davidjiglesias merged commit b8aa493 into 4.8.0 Mar 8, 2024
3 of 4 checks passed
@davidjiglesias davidjiglesias deleted the feature/4991-update-packages-in-TestScanSyscollectorCases branch March 8, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Packages Used in TestScanSyscollectorCases
3 participants