Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jump to comments button present when comments are disabled #3

Closed
wants to merge 6 commits into from
Closed

Fix jump to comments button present when comments are disabled #3

wants to merge 6 commits into from

Conversation

deosrc
Copy link
Contributor

@deosrc deosrc commented Feb 21, 2025

Resolves #1

@wayjam
Copy link
Owner

wayjam commented Feb 22, 2025 •
edited
Loading

Thanks for PR! Maybe it 's better to use {{- $enableComments := and (not .Site.Params.comment.disabled) (not (in .Site.Params.comment.disableByType .Type)) -}}

@deosrc deosrc changed the base branch from main to develop February 22, 2025 12:01
@deosrc
Copy link
Contributor Author

deosrc commented Feb 22, 2025

Thanks for PR! Maybe it 's better to use {{- $enableComments := and (not .Site.Params.comment.disabled) (not (in .Site.Params.comment.disableByType .Type)) -}}

Good spot. Updated. I've also repointed the PR to develop and resolved the conflicts.

@wayjam wayjam changed the base branch from develop to main February 23, 2025 09:21
@wayjam wayjam self-assigned this Feb 23, 2025
@wayjam
Copy link
Owner

wayjam commented Feb 25, 2025

Manual merged on develop.

@wayjam wayjam closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wayjam wayjam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] "Jump to comments" link still present when comments are disabled
2 participants
@deosrc @wayjam