Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pluralization support #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donmasakayan
Copy link

Allows for auths/ instead of auth/ when pluralization is enabled.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 677a871 on donmasakayan:pluralization_support into * on waterlock:master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 677a871 on donmasakayan:pluralization_support into * on waterlock:master*.

@Globegitter
Copy link
Contributor

Wouldn't you be be able to access the blueprints config for that? I think that would be best to just take that - to keep it as simple as possible.

@donmasakayan
Copy link
Author

Yes, that would be much more ideal. I was just implementing the same thing in waterlock-facebook-auth, line 27 for consistency. As such, both would need to be changed.

@wayne-o
Copy link
Contributor

wayne-o commented Feb 22, 2015

Did I not do this? Maybe I didn't create a PR

pretty sure I have. If you can wait until tomorrow morning I can create a
PR for the fb repo

On Sunday, 22 February 2015, donmasakayan notifications@github.com wrote:

Yes, that would be much more ideal. I was just implementing the same thing
in waterlock-facebook-auth, line 27
https://github.com/waterlock/waterlock-facebook-auth/blob/master/lib/waterlock-facebook-auth.js#L27.
As such, both would need to be changed.


Reply to this email directly or view it on GitHub
#20 (comment)
.

--------------------

w://

t: 07508 215 459

--------------------

@duhruh
Copy link
Member

duhruh commented Feb 22, 2015

Thanks a bunch @donmasakayan but @Globegitter has a good point, this seems a little too "insider baseball" can we not solve this with blueprints?

@wayne-o
Copy link
Contributor

wayne-o commented Feb 23, 2015

ok, so turns out I am just going up to waterlock.js:

https://github.com/waterlock/waterlock-facebook-auth/blob/master/lib/waterlock-facebook-auth.js#L9

How would I go about doing this using blueprints? If someone can give me some pointers I'll create a PR for fb and local auths

@Globegitter
Copy link
Contributor

@wayne-o I have accessed the sails config before, but can't remember anymore how I did it. There is a global sails.config in your app and in hooks you get it passed, see https://github.com/balderdashy/sails-hook-dev/blob/master/index.js#L33

Hope this helps a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants