Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ldflags when building multi binaries #178

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Support ldflags when building multi binaries #178

merged 1 commit into from
Dec 6, 2024

Conversation

joaoubaldo
Copy link
Contributor

LDFLAGS_PREFIX and INPUT_LDFLAGS are missing from the multi binary build logic.

@wangyoucao577 wangyoucao577 merged commit d4bf7aa into wangyoucao577:master Dec 6, 2024
1 check passed
@wangyoucao577
Copy link
Owner

Thanks for the contribution! Unfortunately, it'll fail the testing. Would you please help to fix it? https://github.com/wangyoucao577/go-release-action/actions/runs/12201486402/job/34040007059

wangyoucao577 added a commit that referenced this pull request Dec 7, 2024
@wangyoucao577
Revert "Support ldflags building multi binaries (#178)"
116675e 
This reverts commit d4bf7aa.
@wangyoucao577 wangyoucao577 mentioned this pull request Dec 7, 2024
Merged
wangyoucao577 added a commit that referenced this pull request Dec 7, 2024
@wangyoucao577
Revert "Support ldflags building multi binaries (#178)" (#179)
9942c22 
This reverts commit d4bf7aa.
@wangyoucao577
Copy link
Owner

@joaoubaldo I have reverted the PR for now. Welcome new PR once the issue fixed, thanks!

@joaoubaldo joaoubaldo mentioned this pull request Dec 9, 2024
Merged
@joaoubaldo
Copy link
Contributor Author

Thanks for the contribution! Unfortunately, it'll fail the testing. Would you please help to fix it? https://github.com/wangyoucao577/go-release-action/actions/runs/12201486402/job/34040007059

Follow up PR #180.
It might be a good idea to include the testing workflow to be triggered when a PR is updated to prevent broken PRs from being merged.

@wangyoucao577
Copy link
Owner

Thanks for the contribution! Unfortunately, it'll fail the testing. Would you please help to fix it? https://github.com/wangyoucao577/go-release-action/actions/runs/12201486402/job/34040007059

Follow up PR #180. It might be a good idea to include the testing workflow to be triggered when a PR is updated to prevent broken PRs from being merged.

Absolutely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaoubaldo @wangyoucao577