Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gomips support #173

Merged
merged 1 commit into from
Jun 15, 2024
Merged

feat: add gomips support #173

merged 1 commit into from
Jun 15, 2024

Conversation

xrz-cloud
Copy link
Contributor

@xrz-cloud xrz-cloud commented Jun 10, 2024 •
edited
Loading

Add GOMIPS support when building for mips devices(like some openwrt routers).
GOMIPS can be set to hardfloat(default) or softfloat.

@wangyoucao577 wangyoucao577 merged commit d5316f1 into wangyoucao577:master Jun 15, 2024
1 check passed
@wangyoucao577
Copy link
Owner

Thanks very much! wangyoucao577/go-release-action@v1.51 now ready for you.

@lslqtz
Copy link
Contributor

lslqtz commented Jun 20, 2024

Nice work, but I want to point out that GOMIPS may not work with mips64 and mips64le.

Ref: https://pkg.go.dev/cmd/go@go1.20.13

For GOARCH=mips or mipsle, GOMIPS=hardfloat and softfloat correspond to the mips.hardfloat and mips.softfloat (or mipsle.hardfloat and mipsle.softfloat) feature build tags.
For GOARCH=mips64 or mips64le, GOMIPS64=hardfloat and softfloat correspond to the mips64.hardfloat and mips64.softfloat (or mips64le.hardfloat and mips64le.softfloat) feature build tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrz-cloud @wangyoucao577 @lslqtz